Reworked the EditableTextPrompt to better handle long values#73
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Reworks EditableTextPrompt to support horizontal scrolling for long inputs so editing remains usable within narrow console widths.
Changes:
- Add horizontal scrolling window logic with left/right scroll indicators in
EditableTextPrompt.Render(). - Update render call sites to pass strings (instead of the
StringBuilder) and introduce helper methods for windowing/cursor rendering. - Add new prompt tests that exercise long-input editing scenarios under a narrow console width.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/Karls.BetterSecretsTool/Prompts/EditableTextPrompt.cs |
Implements horizontal scrolling and new rendering/windowing logic for long text inputs. |
test/Karls.BetterSecretsTool.Tests/Prompts/EditableTextPromptTests.cs |
Adds new long-text prompt interaction tests under constrained console width. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.