run ./build-docker.sh again before pushing karate images to registry
#2574
Conversation
| @@ -56,6 +56,7 @@ jobs: | |||
| - name: docker push | |||
| if: ( github.event.inputs.docker == 'enabled' ) | |||
| run: | | |||
| ./build-docker.sh | |||
There was a problem hiding this comment.
@daviddavidgit @jandry this is already there on line 49 so I don't think this makes a difference
There was a problem hiding this comment.
should we change build-docker.sh to use 2 different cache names just a thought ?
There was a problem hiding this comment.
I let the build-docker.sh script run again because of this error:
ERROR: failed to solve: failed to compute cache key: failed to calculate checksum of ref yaxwzuev1m6uf4pxk3pkre55l::rjnz27nhlipnmbx7zwlwerocm: "/target/repository": not found
I thought the runs within a step share the workspace, but does not seem the case.
There was a problem hiding this comment.
well the buildx runs twice but with the same "cache name". hence my comment. I'll wait until we have more clarity. again, it should be easy for anyone to set up a git project and a personal docker repo and try
Description
Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the
developbranch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.