Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make JDK 11 the minimum version #2083

Closed
ptrthomas opened this issue Aug 3, 2022 · 14 comments
Closed

make JDK 11 the minimum version #2083

ptrthomas opened this issue Aug 3, 2022 · 14 comments
Assignees
Milestone

Comments

@ptrthomas
Copy link
Member

ptrthomas commented Aug 3, 2022

refer discussion in 2009 on Jun 7

plan is:

  • version 1.3.0 of Karate (which solves the Graal JS issues) will be the last release that uses JDK 8
  • version 1.4.X onwards Karate will require Java 11 (note that 1.4.0.RC3 is already available to test)
  • version 1.5.0 onwards the Maven artifact and Java package names will change to io.karatelabs

edit1 to announce 1.4.0.RC1 and that 1.5.0 will be where we move packages

@ptrthomas
Copy link
Member Author

this ticket will also track

  • the switch of Karate's maven namespace to io.karatelabs.karate and the corresponding Java package changes
  • we can also take this opportunity to drop JUnit4 support completely

@ptrthomas
Copy link
Member Author

ptrthomas commented Aug 24, 2022

note to self: we need to move the docker container to the karatelabs org: https://hub.docker.com/r/karatelabs/karate-chrome

existing: https://hub.docker.com/r/ptrthomas/karate-chrome

for the record, pull-count is 745965 as of now: https://hub.docker.com/v2/repositories/ptrthomas/karate-chrome/

@ptrthomas
Copy link
Member Author

there's a report of classgraph having a vulnerability, so make sure to upgrade that in this ticket: https://ossindex.sonatype.org/component/pkg:maven/io.github.classgraph/classgraph

@ptrthomas
Copy link
Member Author

update: classgraph was upgraded in develop and will make it in the final release of 1.3.0 - any team depending on this is requested to verify

@ptrthomas
Copy link
Member Author

reminder to upgrade picocli to 4.7.0 https://github.com/remkop/picocli/releases/tag/v4.7.0

@ptrthomas
Copy link
Member Author

anyone landing here, please note - a Karate version for Java 11 (plus Graal update) is already available as 1.4.0.RC1 see #2148

@ptrthomas
Copy link
Member Author

note a request to update the ANTLR dep in #2174

@ptrthomas ptrthomas added this to the 1.4.0 milestone Dec 7, 2022
@edwardsph
Copy link
Contributor

Is there any possibility of doing a 1.4.0.RC2 release which will bring in the recent improvements from 1.3.1. Could that also include the ANTLR update as well please? I'd like to keep tracking the 1.4.0 releases but I have a clash with ANTLR versions and I'm not keen to use the "all" classifier as it re-introduces vulnerable dependencies we've previously replaced.

@ptrthomas
Copy link
Member Author

@edwardsph sure. will try in the next day or two. wonder if you had a chance to look at this

@edwardsph
Copy link
Contributor

Sadly I didn't have the capacity but that's partly the reason for the above request, so I can have a look at those changes in the context of 1.4.0. It was tricky for me to revert to 1.3.1.

ptrthomas added a commit that referenced this issue Dec 12, 2022
failed thymeleaf and slf4j - needs investigation
@ptrthomas
Copy link
Member Author

all: 1.4.0.RC2 was released and should be available in maven central shortly. in addition to the fixes in 1.3.1 - here are the dependencies updated to latest versions: 05bd6af

@ptrthomas
Copy link
Member Author

dev note: we will drop cucumber and the fake classes in 1.4.0: #2214

@ptrthomas
Copy link
Member Author

for anyone landing here, 1.4.0.RC3 is available.

note for 1.5.0 - we will stop releasing the ZIP release as this need is covered by the plugins (VS Code and IntelliJ): https://github.com/karatelabs/karate/wiki/ZIP-Release

ptrthomas added a commit that referenced this issue Jan 31, 2023
ptrthomas added a commit that referenced this issue Jan 31, 2023
also switched some tests to use junit5
ptrthomas added a commit that referenced this issue Feb 2, 2023
also refer #2083 we have removed karate-mock-servlet
junit4 was removed in a previous commit
@ptrthomas ptrthomas added the fixed label Apr 2, 2023
@ptrthomas
Copy link
Member Author

1.4.0 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants