Skip to content

Conversation

@JAGADISHSUNILPEDNEKAR
Copy link
Contributor

This PR implements automatic handling of witness data for non-witness inputs in SegWit transactions:

  • Added logic to automatically add empty witnesses (0x00) for non-SegWit inputs
  • Ensures proper serialization of mixed input transactions
  • Maintains backward compatibility with existing code

Test Updates:

  • Added tests for automatic witness handling in mixed input transactions

All the tests pass
Screenshot 2025-03-30 at 2 57 00 AM

@JAGADISHSUNILPEDNEKAR
Copy link
Contributor Author

JAGADISHSUNILPEDNEKAR commented Apr 2, 2025

Hi @karask
Could you please let me know your feedback on this

@karask
Copy link
Owner

karask commented Apr 3, 2025

Too many changes are happening in this file. There is a PR (137) that is close of being merged that offered a solution to add the 00 hex. There is also code to add the annex here, after repeatedly made clear that I need a single change per PR.

For the above reasons I will close. Wait to see how the PR #137 goes before you work on those.

@karask karask closed this Apr 3, 2025
@JAGADISHSUNILPEDNEKAR
Copy link
Contributor Author

Hi @karask
Before creating this PR I went through his implementation
the way we both are integrating are a bit different
Is the way of implementation of his code better? Or is it solely dependent on that I have created many changes
just needed a clarification :)

@JAGADISHSUNILPEDNEKAR
Copy link
Contributor Author

His implementation requires a manual addition of an empty witness for non-SegWit inputs in SegWit transactions but the way I implemented it was to implement the same thing automatically
I have some unclarity as to why this was closed , Would be glad @karask if I get a detailed feedback on this
That would be quite helpful for me to contribute further in a much better manner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants