Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix back button issue in the import lyric screen #1256

Conversation

andy840119
Copy link
Member

What's fixed in this PR:

  • Remove the back button because it will hide the lyric editor.
  • Should exit import screen only if in the drag screen(first import lyric step)
  • Add abort import feature in the import manager.
  • Checking able to roll-back to the target page instead of checking current page if user click the back button.

Also, should make sure that all the processing step should be cleared(Because use already confirmed abort action).
@andy840119 andy840119 added bug Something isn't working code quality Improve code quality. labels Apr 2, 2022
@andy840119 andy840119 added this to the 2022.0416 milestone Apr 2, 2022
@andy840119
Copy link
Member Author

Also, there's something found but not fixed in this PR(might create another issue for it):

  • Should be better to press Esc to go-back to previous screen.
  • Should think about should show the popover if change the step by fixing invalid part by lyric maker.

@andy840119 andy840119 merged commit 5001bbf into karaoke-dev:master Apr 2, 2022
@andy840119 andy840119 deleted the fix-back-button-issue-in-the-import-lyric-screen branch April 2, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code quality Improve code quality. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant