Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify mutability of concurrent hash when each_value is running #218

Closed
mensfeld opened this issue Nov 30, 2021 · 1 comment · Fixed by #219
Closed

Verify mutability of concurrent hash when each_value is running #218

mensfeld opened this issue Nov 30, 2021 · 1 comment · Fixed by #219
Labels
bug

Comments

@mensfeld
Copy link
Member

A corner case came to my mind. During the concurrent hash iteration, we may modify it. It should either work or we should extract values and iterate on them while injecting new callbacks.
@mensfeld
Copy link
Member Author 

can't add a new key into hash during iteration (RuntimeError)

@mensfeld mensfeld added the bug label Nov 30, 2021
mensfeld added a commit that referenced this issue Nov 30, 2021
@mensfeld
#218 - callbacks manager concurrency fix
4ee8167
@mensfeld mensfeld mentioned this issue Nov 30, 2021
Merged
mensfeld added a commit that referenced this issue Dec 1, 2021
@mensfeld
#218 - callbacks manager concurrency fix (#219)
cec47d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#218 - callbacks manager concurrency fix karafka/waterdrop
1 participant
@mensfeld