v2.4.4 (#284)

karafka · Dec 9, 2022 · dbbbb5b · dbbbb5b
1 parent a6a1f16
commit dbbbb5b
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,6 @@
 # WaterDrop changelog
 
-## Unreleased
+## 2.4.4 (2022-12-09)
 - Add temporary patch on top of `rdkafka-ruby` to mitigate metadata fetch timeout failures.
 
 ## 2.4.3 (2022-12-07)

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    waterdrop (2.4.3)
+    waterdrop (2.4.4)
       karafka-core (>= 2.0.6, < 3.0.0)
       zeitwerk (~> 2.3)
 

diff --git a/lib/waterdrop/patches/rdkafka/metadata.rb b/lib/waterdrop/patches/rdkafka/metadata.rb
@@ -8,8 +8,9 @@ module Rdkafka
       # Rdkafka::Metadata patches
       module Metadata
         # We overwrite this method because there were reports of metadata operation timing out
-        # when Kafka was under stress. While the messages dispatch will be retried, this was not
-        # and was causing problems.
+        # when Kafka was under stress. While the messages dispatch will be retried, metadata
+        # fetch happens prior to that, effectively crashing the process. Metadata fetch was not
+        # being retried at all.
         #
         # @param args [Array<Object>] all the metadata original arguments
         def initialize(*args)

diff --git a/lib/waterdrop/version.rb b/lib/waterdrop/version.rb
@@ -3,5 +3,5 @@
 # WaterDrop library
 module WaterDrop
   # Current WaterDrop version
-  VERSION = '2.4.3'
+  VERSION = '2.4.4'
 end