Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rewrite compileStyledText parser #472

Merged
merged 3 commits into from
Oct 22, 2024
Merged

fix: rewrite compileStyledText parser #472

merged 3 commits into from
Oct 22, 2024

Conversation

dragoncoder047
Copy link
Contributor

@dragoncoder047 dragoncoder047 commented Oct 22, 2024 •
edited
Loading

now throws errors if the tags aren't proper or otherwise escaped

closes #448

@dragoncoder047
rewrite compileStyledText parser
abea276
@dragoncoder047
fix failing test
ea260ff 
now needs to be escaped!! as it should have been all along!!
@dragoncoder047 dragoncoder047 marked this pull request as draft October 22, 2024 00:18
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 22, 2024 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/kaplayjs/kaplay@472

commit: 48efb87

@dragoncoder047 dragoncoder047 marked this pull request as ready for review October 22, 2024 00:36
@niceEli niceEli changed the title rewrite compileStyledText parser fix: rewrite compileStyledText parser Oct 22, 2024
@lajbel lajbel merged commit b1058a6 into kaplayjs:master Oct 22, 2024
2 checks passed
lajbel pushed a commit that referenced this pull request Oct 22, 2024
@dragoncoder047 @lajbel
fix: rewrite compileStyledText parser (#472)
f5ed469
@dragoncoder047 dragoncoder047 deleted the textparser branch October 22, 2024 20:54
@dragoncoder047 dragoncoder047 mentioned this pull request Oct 23, 2024
Merged
@dragoncoder047 dragoncoder047 restored the textparser branch November 15, 2024 14:46
@dragoncoder047 dragoncoder047 deleted the textparser branch November 15, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niceEli niceEli niceEli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
KAPLAY.js
Status: DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: impossible to cleanly escape ] in formatted text
3 participants
@dragoncoder047 @niceEli @lajbel