Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add some examples to some comps #466

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

amyspark-ng
Copy link
Contributor

yea

@@ -368,7 +368,18 @@ export interface KAPLAYCtx<
*
* @param a The angle to rotate by. Defaults to 0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be worthwhile to note that angles for this are in degrees, some other game libs use radians

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true

Copy link
Contributor Author

@amyspark-ng amyspark-ng Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't it already say (in degrees)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh duh, it was the line that got cut off by the GitHub diff

@amyspark-ng
Copy link
Contributor Author

if it's good then push pls

@niceEli
Copy link
Member

niceEli commented Oct 22, 2024

conflicts fixed

Copy link

pkg-pr-new bot commented Oct 22, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/kaplayjs/kaplay@466

commit: a9aa52c

@niceEli niceEli merged commit 5f98a01 into kaplayjs:master Oct 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants