-
Notifications
You must be signed in to change notification settings - Fork 3
Description
Ran into a couple of issues with the current CMakeLists.txt
:
-
Deprecated
FindCUDA.cmake
: The project uses the oldfind_package(CUDA)
command, which is no longer supported in newer CMake versions. This causes errors or warnings during the build on updated systems. -
Hardcoded Conda Path: The CMake file has a hardcoded path to a specific Conda environment (
/home/ksharma/anaconda3/envs/cuda-learn
), which makes it non-portable. Developers have to manually change this path to match their setup. -
Manual
wget
forlibtorch
: The commented-outwget
command for downloadinglibtorch
requires manual uncommenting.
Suggested Fixes:
- Switch to native CUDA support (
enable_language(CUDA)
) and remove the oldfind_package(CUDA)
. - Replace the hardcoded Conda path with dynamic detection using the
CONDA_PREFIX
environment variable. - Check if the download is required, automate the download and extraction of
libtorch
directly in the CMake process to streamline setup.
These changes will make the project easier to build and more portable. The pull request #1 updates these issues if you see it relevant.