Kaovilai patch 2 - #13
Merged
Merged
Conversation
kaovilai
added a commit
that referenced
this pull request
Jul 30, 2021
….io/cnr URLs (openshift#156) * Update docs-actions.yml (#12) * Kaovilai patch 2 (#13) * Exclude quay.io/cnr
kaovilai
added a commit
that referenced
this pull request
Aug 6, 2026
Fixed an error I introduced last round: claimed delete-then-retry 'does not reliably unblock' the VMB run-state gate, adding an unverified 'race with controller cache' caveat that was never confirmed by kdm-controller. What they actually verified is that delete-then-retry DOES mechanically unblock it - it's just an undocumented manual workaround with no product-level support, not a broken mechanism. Corrected the wording to match what was verified. Also added force-full-backup annotation provenance: introduced in kubevirt-datamover-controller PR #13 (mpryc) as part of a squashed Phase 4 commit; no PR discussion, commit message, or linked issue documents why DataUpload-level was chosen over the originally-proposed Backup-level annotation - attributed as undocumented rather than inferring a rationale. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.