Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session 6: Lifecycle of UIViewController #5

Merged
merged 4 commits into from
Feb 26, 2024
Merged

Session 6: Lifecycle of UIViewController #5

merged 4 commits into from
Feb 26, 2024

Conversation

kantacky
Copy link
Owner

@kantacky kantacky commented Feb 16, 2024 •
edited
Loading

Session 6: Lifecycle of UIViewController

Updates

  • NewViewを追加
  • .fullScreenCoverモディファイアを追加
  • NewViewが表示されたタイミングでfullScreenCoverによってForecastViewを表示する処理を実装
  • ForecastViewのCloseボタンを押したらdismiss()を呼ぶ処理を実装
  • fullScreenCoverのonDismissアクションによってfullScreenCoverのisPresentedをtrueにして再表示する処理を実装

Issues

  • 課題での要件を満たしているか？
  • コミットを分けるべきだった

@kantacky kantacky requested review from a team February 19, 2024 02:34
@kiy00 kiy00 self-requested a review February 21, 2024 06:32
ykws
ykws reviewed Feb 21, 2024
View reviewed changes
YumemiTraining/ForecastView.swift Outdated Show resolved Hide resolved
YumemiTraining/ForecastViewModel.swift Outdated Show resolved Hide resolved
@kantacky kantacky requested a review from ykws February 21, 2024 08:07
macneko-ayu
macneko-ayu approved these changes Feb 22, 2024
View reviewed changes
Copy link

@macneko-ayu macneko-ayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

命名が気にはなりますが、内容はよさそうです

kiy00
kiy00 approved these changes Feb 22, 2024
View reviewed changes
Copy link

@kiy00 kiy00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kantacky kantacky force-pushed the session/6 branch 2 times, most recently from ee9f8f6 to e0b68df Compare February 22, 2024 08:30
Base automatically changed from session/4 to main February 26, 2024 04:14
@kantacky kantacky merged commit d5ffb80 into main Feb 26, 2024
@kantacky kantacky deleted the session/6 branch February 26, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macneko-ayu macneko-ayu macneko-ayu approved these changes

@kiy00 kiy00 kiy00 approved these changes

@ykws ykws Awaiting requested review from ykws

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kantacky @macneko-ayu @ykws @kiy00