Private base64 field #433
Merged
Private base64 field #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing Deref/Borrow/etc.
micolous
approved these changes
Apr 25, 2024
2 tasks
Closed
kikuomax
pushed a commit
to codemonger-io/webauthn-rs
that referenced
this pull request
Nov 24, 2024
* Remove usage of the inner fields of Base64UrlSafeData, in favour of using Deref/Borrow/etc. * fix formatting * fixup win10 * Remove dependency on base64urlsafedata string formatting, fixup some mozilla issues * Base64UrlSafeData: remove FromStr and Display impl * fixup win10 * Updated * Wrap up * key manager * CI --------- Co-authored-by: Michael Farrell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #356
Fixes #352
Goal is to remove all functionality from
Base64UrlSafeDatawhich is not about serialisation, and stop dependants from using internal-only interfaces.HumanBinaryDatawon't provide these interfaces, so it needs to make do.Make
Base64UrlSafeData.0(the innerVec<u8>) private, likeHumanBinaryData.This switches over everything which used the inner field to using
From,Derefor::new(). These interfaces are also available onHumanBinaryData, and makes the types pretty much interchangable.Remove
impl Display for Base64UrlSafeData(which converted the inner value into a Base64 string).The alternative is to use
base64::Engine::encode.Remove
impl TryFrom<&str> for Base64UrlSafeData(which attempted to parse strings as Base64).The alternative is to use
base64::Engine::decode.Migrate
WinWrapper::newto use owned types rather than pass-by-reference.Most of the existing implementations made copies of that data, and callers don't need to clone anyway.