20231025 attestation ca devices #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstyear
requested review from
yaleman,
agrinman and
micolous
as code owners
micolous
requested changes
Nov 23, 2023
|
I think wait for #392; that'll make CI green again :) |
|
yep, no stress. |
Firstyear
force-pushed
the
20231025-attestation-ca-devices
branch
from
3342c53 to
6130fc2
Compare
Firstyear
force-pushed
the
20231025-attestation-ca-devices
branch
from
f80bc0b to
2b8635e
Compare
micolous
previously approved these changes
Nov 24, 2023
micolous
approved these changes
Nov 25, 2023
kikuomax
pushed a commit
to codemonger-io/webauthn-rs
that referenced
this pull request
Nov 24, 2024
Cherry-picking note: - Rewrites the newly introduced code that depends on OpenSSL so that it does not depend on OpenSSL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes some of the last details to make attestation usable in external applications. It improves the AttestationCaList type to include localised strings of accepted devices for UI prompts. It creates an AttestationCaListbuilder to allow custom lists to be crafted. It also cleans up some of the elements of the fido mds tool output to aid users in querying and creating these lists. It also changes the demo site to use the fido mds as an attestation option.