Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port from axum-sessions to tower-sessions #389

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

Cogitri
Copy link
Contributor

@Cogitri Cogitri commented Nov 21, 2023

The former has been deprecated

Tested register+login locally

The former has been deprecated
@Cogitri
Copy link
Contributor Author

Cogitri commented Nov 21, 2023

I've also ported from axum-extras to tower-http in this PR, since the change is pretty small. If you prefer two PRs, we can split the two commits into two PRs.

Copy link
Member

@yaleman yaleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaleman
Copy link
Member

yaleman commented Nov 22, 2023

Looks like the CI fails aren't part of this change?

@Firstyear Firstyear merged commit a0cb1e8 into kanidm:master Nov 22, 2023
31 of 33 checks passed
@Firstyear
Copy link
Member

Thank you!

kikuomax pushed a commit to codemonger-io/webauthn-rs that referenced this pull request Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants