Minor changes for kani release #380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstyear
requested review from
yaleman,
agrinman and
micolous
as code owners
yaleman
previously approved these changes
Oct 31, 2023
|
@micolous We're gonna need to do something to get away from the git rev versions here so we can do releases in future I think. |
yaleman
reviewed
Nov 1, 2023
yaleman
previously approved these changes
Nov 1, 2023
|
I'd like @micolous input before I proceed on this :) |
micolous
approved these changes
Nov 14, 2023
micolous
requested changes
Nov 14, 2023
micolous
reviewed
Nov 14, 2023
fido-key-manager/src/main.rs
Outdated
| @@ -13,7 +13,7 @@ use std::time::Duration; | |||
| use tokio_stream::StreamExt; | |||
| #[cfg(feature = "solokey")] | |||
| use webauthn_authenticator_rs::ctap2::SoloKeyAuthenticator; | |||
| use webauthn_authenticator_rs::prelude::WebauthnCError; | |||
| // use webauthn_authenticator_rs::prelude::WebauthnCError; | |||
There was a problem hiding this comment.
This should be gated on #[cfg(feature = "solokey")] to fix the warning and not break when that feature is enabled.
|
@micolous We had a bunch of issues generally, because we can't use git versions of things on crates.io, which meant btleplug was problematic. So we probably generally have a bunch of cleanup to get to a releasable state, which I want to do "sooner than later" |
Firstyear
force-pushed
the
20231031-kani-release
branch
from
7a2761c to
a380f08
Compare
|
I dunno what I just did, but I think I cooked this PR 🤣 I think I close it in favour of another attempt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.