Add "HumanBinaryData" as an alternative to "Base64UrlSafeData" #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micolous
requested review from
Firstyear,
yaleman and
agrinman
as code owners
Closed
micolous
force-pushed
the
human
branch
3 times, most recently
from
b26169b to
1d7d75d
Compare
2 tasks
kikuomax
pushed a commit
to codemonger-io/webauthn-rs
that referenced
this pull request
Nov 24, 2024
…m#354) * Add "HumanBinaryData" as alternative to "Base64UrlSafeData" (kanidm#352) * Add bytes support to Base64UrlSafeData, and copy across the tests * Rework the docs * dedupe functionality into macros, make tests consistent * more tests and conversions * move Borrow impl into common * add some more vec features * fix clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #352, it doesn't fix things, but it's a start.
HumanBinaryDatauses a more efficient "bytes" format when using non-human-readable serialisation formats (like CBOR). The deserialiser still usesdeserialize_any– I haven't got a great way around this yet.I've done a few things differently to
Base64UrlSafeData; for example, this doesn't implementDisplayorFromStr– they're different to whatVec<u8>does, and we should move away from this (this will be the focus of #356).It also implements
DerefandDerefMut, which should make the type more transparent – and all of the common impls are in macros.I've added
bytessupport toBase64UrlSafeData, so it can read whatHumanBinaryDataproduces. Unfortunately this makes migration a two-step process.While we're here, this makes
serde_jsona dev-dependency ofbase64urlsafedata, because it's only used in tests; and this also adds a bunch more tests for expected input formats.