Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #352 - This adds a hidden feature that allows the storage of vec to skip base64 for some users.
We can't apply this into base64urlsafedata because features taint and having a flag to skip base64 would break wasm and json front ends. So as a result, the only way to proceed is to swap the type in the struct based on the cfg flag. It is a teeny bit messy because it introduces some useless into()/from() where without the feature we are doing base64 into base64, but it's needed when the feature is enabled.
I can't think of a better way to actually achieve this though without breaking existing users horrendously. @micolous do you have any better ideas perhaps?