Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

352 serde bincode #353

Closed
wants to merge 2 commits into from
Closed

Conversation

Firstyear
Copy link
Member

Fixes #352 - This adds a hidden feature that allows the storage of vec to skip base64 for some users.

We can't apply this into base64urlsafedata because features taint and having a flag to skip base64 would break wasm and json front ends. So as a result, the only way to proceed is to swap the type in the struct based on the cfg flag. It is a teeny bit messy because it introduces some useless into()/from() where without the feature we are doing base64 into base64, but it's needed when the feature is enabled.

I can't think of a better way to actually achieve this though without breaking existing users horrendously. @micolous do you have any better ideas perhaps?

  • [ x ] cargo test has been run and passes
  • documentation has been updated with relevant examples (if relevant)

@yaleman
Copy link
Member

yaleman commented Sep 28, 2023

looks like some of the tests are still salty about the redundant stuff..

@Firstyear
Copy link
Member Author

Yes, I wanted some input from @micolous first before I finish tidying that up

@smessmer
Copy link
Contributor

I believe an approach not relying on features is better. See the discussion here in and some example code here

@Firstyear
Copy link
Member Author

Yeah. We think there are better ways.

@Firstyear Firstyear closed this Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bincode serialization
3 participants