Refactor parameter types: change some String parameters to traits and…

[kolapapa]

When constructing the LdapClient using LdapClientBuilder, there is no need for the user to manually construct the URL as a Url type before passing it in. Instead, it should be automatically converted to a Url type by the library during the actual build process, which can enhance the user experience. The same reasoning applies to the basedn in other client query operations.

[Firstyear]

I like the into change, but I'd like the URL change reverted. Currently, by having the url as part of clap, it means we get really good errors on the cli like:

error: Invalid value "ldap" for '--url <URL>': relative URL without a base

Where as with this change, we'd only get "InvalidUrl".

It also means callers to our library pass in a Url and can handle the errors there too in a better way than we can.

So can you please revert the URL change?

[kolapapa]

I like the into change, but I'd like the URL change reverted. Currently, by having the url as part of clap, it means we get really good errors on the cli like:

error: Invalid value "ldap" for '--url <URL>': relative URL without a base

Where as with this change, we'd only get "InvalidUrl".

It also means callers to our library pass in a Url and can handle the errors there too in a better way than we can.

So can you please revert the URL change?

I think this LdapError needs some optimization. The current displayed error message is too limited and does not allow for personalized output.

[Firstyear]

That's the output from Clap + Url you're seeing there.

LdapError isn't meant to have deep personalised output for a command line or whatever. It's why we would prefer to have the URL parsed first by the caller who can handle and get better output there.

We do want to improe error handling in future, to make unique errors per raise site, but that's ongoing.