Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private Datasets, "Create a new dataset" page: Unlock dataset visibility selection #411

Open
Tracked by #172
s373r opened this issue Sep 3, 2024 · 0 comments · May be fixed by #414
Open
Tracked by #172

Private Datasets, "Create a new dataset" page: Unlock dataset visibility selection #411

s373r opened this issue Sep 3, 2024 · 0 comments · May be fixed by #414
Assignees
@dmitriy-borzenko

Comments

@s373r
Copy link
Member

s373r commented Sep 3, 2024 •
edited
Loading

At the moment, we have the radio button group disabled on the new dataset creation page.

The purpose of this ticket is to activate these controls and then use them.

Details

Added datasetVisibility parameter to the GQL methods DatasetsMut::createEmpty() and DatasetsMut::createFromSnapshot():

enum DatasetVisibility {
	PRIVATE
	PUBLIC
}

...

type DatasetsMut {
	...

	"""
	Creates a new empty dataset
	"""
	createEmpty(
		datasetKind: DatasetKind!,
		datasetAlias: DatasetAlias!, 
+		datasetPubliclyAvailable: Boolean
	): CreateDatasetResult!

	"""
	Creates a new dataset from provided DatasetSnapshot manifest
	"""
	createFromSnapshot(
		snapshot: String!,
		snapshotFormat: MetadataManifestFormat!
+		datasetPubliclyAvailable: Boolean
	): CreateDatasetFromSnapshotResult!

	...
}
This was referenced Sep 3, 2024
Open
Open
@s373r s373r changed the title Private Dataset, "Create a new dataset" page: Unlock dataset visibility selection Private Datasets, "Create a new dataset" page: Unlock dataset visibility selection Sep 3, 2024
@dmitriy-borzenko dmitriy-borzenko self-assigned this Sep 4, 2024
@dmitriy-borzenko dmitriy-borzenko linked a pull request Sep 4, 2024 that will close this issue
Open
@dmitriy-borzenko dmitriy-borzenko linked a pull request Sep 4, 2024 that will close this issue
Kamu UI 411 private datasets create a new dataset page unlock dataset visibility selection #414
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitriy-borzenko dmitriy-borzenko

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@s373r @dmitriy-borzenko