Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private Datasets: GQL: make new parameters mandatory, after frontend update #780

Open
Tracked by #676
s373r opened this issue Aug 19, 2024 · 0 comments
Open
Tracked by #676
Assignees

Comments

@s373r
Copy link
Member

s373r commented Aug 19, 2024

An optional argument for creating datasets via GQL has been added for now:


Once kamu-web has done the migration and the changes have been pushed to the deployed environments, make the added argument mandatory:

type DatasetsMut {
	...

	Creates a new empty dataset
	"""
	createEmpty(
		datasetKind: DatasetKind!,
		datasetAlias: DatasetAlias!, 
-		datasetPubliclyAvailable: Boolean
+		datasetPubliclyAvailable: Boolean!
	): CreateDatasetResult!

	"""
	Creates a new dataset from provided DatasetSnapshot manifest
	"""
	createFromSnapshot(
		snapshot: String!,
		snapshotFormat: MetadataManifestFormat!
-		datasetPubliclyAvailable: Boolean
+		datasetPubliclyAvailable: Boolean!
	): CreateDatasetFromSnapshotResult!

	...
}

A task to update the frontend:

@s373r s373r self-assigned this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant