Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix escaping in ParquetJson schema formatter, add JSON_AOS format alias #925

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Fix escaping in ParquetJson schema formatter, add JSON_AOS format alias #925

merged 1 commit into from
Oct 27, 2024

Conversation

sergiimk
Copy link
Member

Description

Closes: #746

  • Removed deprecated JSON_LD in favor of ND_JSON in DataBatchFormat
  • In DataBatchFormat introduced JSON_AOS format to replace the now deprecated JSON in effort to harmonize format names with REST API
  • Fixed invalid JSON encoding in PARQUET_JSON schema format when column names contain special characters

Checklist before requesting a review

@sergiimk sergiimk merged commit 25f8d53 into master Oct 27, 2024
6 checks passed
@sergiimk sergiimk deleted the bug/parquet-json-name-escaping branch October 27, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitriy-borzenko dmitriy-borzenko dmitriy-borzenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GQL API: Schema in query results may contain invalid JSON
2 participants
@sergiimk @dmitriy-borzenko