DatasetEntryService: move list-* operations within an implementation

kamu-data · Jan 16, 2025 · 850df53 · 850df53
1 parent 0869efa
commit 850df53
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 62 deletions.
diff --git a/src/domain/datasets/domain/src/services/dataset_entry_service.rs b/src/domain/datasets/domain/src/services/dataset_entry_service.rs
@@ -7,7 +7,6 @@
 // the Business Source License, use of this software will be governed
 // by the Apache License, Version 2.0.
 
-use database_common::{EntityPageListing, PaginationOpts};
 use internal_error::{ErrorIntoInternal, InternalError};
 use opendatafabric as odf;
 use thiserror::Error;
@@ -16,10 +15,9 @@ use crate::{DatasetEntry, DatasetEntryStream, GetDatasetEntryError};
 
 ////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
 
+// TODO: Private Datasets: tests
 #[async_trait::async_trait]
 pub trait DatasetEntryService: Sync + Send {
-    // TODO: Private Datasets: tests
-    // TODO: Private Datasets: extract to DatasetEntryRegistry?
     fn all_entries(&self) -> DatasetEntryStream;
 
     fn entries_owned_by(&self, owner_id: &odf::AccountID) -> DatasetEntryStream;
@@ -28,17 +26,6 @@ pub trait DatasetEntryService: Sync + Send {
         &self,
         dataset_id: &odf::DatasetID,
     ) -> Result<DatasetEntry, GetDatasetEntryError>;
-
-    async fn list_all_entries(
-        &self,
-        pagination: PaginationOpts,
-    ) -> Result<EntityPageListing<DatasetEntry>, ListDatasetEntriesError>;
-
-    async fn list_entries_owned_by(
-        &self,
-        owner_id: &odf::AccountID,
-        pagination: PaginationOpts,
-    ) -> Result<EntityPageListing<DatasetEntry>, ListDatasetEntriesError>;
 }
 
 ////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

diff --git a/src/domain/datasets/services/src/dataset_entry_service_impl.rs b/src/domain/datasets/services/src/dataset_entry_service_impl.rs
@@ -277,6 +277,30 @@ impl DatasetEntryServiceImpl {
         }
     }
 
+    async fn list_all_entries(
+        &self,
+        pagination: PaginationOpts,
+    ) -> Result<EntityPageListing<DatasetEntry>, ListDatasetEntriesError> {
+        use futures::TryStreamExt;
+
+        let total_count = self
+            .dataset_entry_repo
+            .dataset_entries_count()
+            .await
+            .int_err()?;
+        let entries = self
+            .dataset_entry_repo
+            .get_dataset_entries(pagination)
+            .await
+            .try_collect()
+            .await?;
+
+        Ok(EntityPageListing {
+            list: entries,
+            total_count,
+        })
+    }
+
     async fn list_all_dataset_handles(
         &self,
         pagination: PaginationOpts,
@@ -292,6 +316,30 @@ impl DatasetEntryServiceImpl {
         })
     }
 
+    async fn list_entries_owned_by(
+        &self,
+        owner_id: &odf::AccountID,
+        pagination: PaginationOpts,
+    ) -> Result<EntityPageListing<DatasetEntry>, ListDatasetEntriesError> {
+        use futures::TryStreamExt;
+
+        let total_count = self
+            .dataset_entry_repo
+            .dataset_entries_count_by_owner_id(owner_id)
+            .await?;
+        let entries = self
+            .dataset_entry_repo
+            .get_dataset_entries_by_owner_id(owner_id, pagination)
+            .await
+            .try_collect()
+            .await?;
+
+        Ok(EntityPageListing {
+            list: entries,
+            total_count,
+        })
+    }
+
     async fn list_all_dataset_handles_by_owner_id(
         &self,
         owner_id: &odf::AccountID,
@@ -345,54 +393,6 @@ impl DatasetEntryService for DatasetEntryServiceImpl {
     ) -> Result<DatasetEntry, GetDatasetEntryError> {
         self.dataset_entry_repo.get_dataset_entry(dataset_id).await
     }
-
-    async fn list_all_entries(
-        &self,
-        pagination: PaginationOpts,
-    ) -> Result<EntityPageListing<DatasetEntry>, ListDatasetEntriesError> {
-        use futures::TryStreamExt;
-
-        let total_count = self
-            .dataset_entry_repo
-            .dataset_entries_count()
-            .await
-            .int_err()?;
-        let entries = self
-            .dataset_entry_repo
-            .get_dataset_entries(pagination)
-            .await
-            .try_collect()
-            .await?;
-
-        Ok(EntityPageListing {
-            list: entries,
-            total_count,
-        })
-    }
-
-    async fn list_entries_owned_by(
-        &self,
-        owner_id: &odf::AccountID,
-        pagination: PaginationOpts,
-    ) -> Result<EntityPageListing<DatasetEntry>, ListDatasetEntriesError> {
-        use futures::TryStreamExt;
-
-        let total_count = self
-            .dataset_entry_repo
-            .dataset_entries_count_by_owner_id(owner_id)
-            .await?;
-        let entries = self
-            .dataset_entry_repo
-            .get_dataset_entries_by_owner_id(owner_id, pagination)
-            .await
-            .try_collect()
-            .await?;
-
-        Ok(EntityPageListing {
-            list: entries,
-            total_count,
-        })
-    }
 }
 
 ////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////