Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore TypeDescriptionsAdded & TypeDescriptionRemoved #2162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

foolishell
Copy link

@foolishell foolishell commented Aug 30, 2022

Description

Before, diff --rule ignoreDescriptionChanges does not worked properly: TypeDescriptionRemoved, TypeDescriptionAdded is not called.

Fixes # #2161

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • yarn jest
  • Tested own schema

Test Environment:

  • OS: MacOS
  • @graphql-inspector/cli: 3.3.0
  • NodeJS: 16.15.1

Checklist:

  • I have followed the CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Aug 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
graphql-inspector ✅ Ready (Inspect) Visit Preview Aug 30, 2022 at 10:56AM (UTC)

@foolishell
Copy link
Author

Can anyone check this??

@theguild-bot theguild-bot mentioned this pull request Apr 16, 2023
39 tasks
@TuvalSimha
Copy link
Collaborator

Hey @foolishell,
We did a lot of changes in the past few weeks, can you please rebase and resolve all conflicts? i will review it.
BTW, if this is a new option, please add test to the vitest tests and add this option to the documents.
Thank you very much!

@theguild-bot theguild-bot mentioned this pull request Oct 26, 2023
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants