Add extension fields to error objects thrown from findDeprecatedUsages #2160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
samchungy
changed the title
samchungy
changed the title
samchungy
commented
Aug 24, 2022
| ) | ||
| ); | ||
| } | ||
| } | ||
| }, | ||
| EnumValue(node) { | ||
| const enumVal = typeInfo.getEnumValue(); |
There was a problem hiding this comment.
This part hasn't changed. Just named the variables a little better for consistency with the above sections
This was referenced May 7, 2024
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Description
Adds extra fields to the GraphQLError extensions objects for deprecation errors thrown from
findDeprecatedUsages. This allows users to access the values in the error without needing to parse the error message. This also exports some types for users to use in their codebase as they will likely want to assert against them.Fixes #2159
Type of change
Please delete options that are not relevant.
Screenshots/Sandbox (if appropriate/relevant):
Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as
appropriate
How Has This Been Tested?
Unit Tests
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration
yarn testTest Environment:
@graphql-inspector/...:Checklist:
style guidelines of this project
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...