Skip to content
This repository has been archived by the owner on Apr 22, 2021. It is now read-only.

[enhancement] Added ability to modify setting order. #1938

Merged
merged 8 commits into from
Mar 13, 2021
Merged

[enhancement] Added ability to modify setting order. #1938

merged 8 commits into from
Mar 13, 2021

Conversation

scorbett123
Copy link
Contributor

This enhanced machine learning allows for the filtering of module lists. Either through custom priority, the amount of clicks, or just alphabetically.

Unfortunately, I had to change the names of 2 other settings due to adding a setting to the base Abstract Module that was named the same.

@scorbett123
Copy link
Contributor Author

Part of #1648

@5HT2 5HT2 added --changes-requested Changes need to be made to the pull -gui enhancement labels Feb 15, 2021
@5HT2 5HT2 added this to the 2.03.01 milestone Feb 15, 2021
@5HT2
Copy link
Member

5HT2 commented Feb 15, 2021

I'm not quite sure what the how this relates to #1648 though

@scorbett123
Copy link
Contributor Author

I'm not quite sure what the how this relates to #1648 though

Sort of fits in with Frequently used.

@5HT2
Copy link
Member

5HT2 commented Feb 15, 2021

Ah, I see. My thinking is this might conflict with User custom module categories, depending on how that is implemented.

My intention behind the idea is the user would be able to open the "category editing" and from there drag modules between any category in any order they want, and make their own categories. Preferably with a way to just hide modules from editing and not display them ever.

@scorbett123
Copy link
Contributor Author

Ah, I see. My thinking is this might conflict with User custom module categories, depending on how that is implemented.

My intention behind the idea is the user would be able to open the "category editing" and from there drag modules between any category in any order they want, and make their own categories. Preferably with a way to just hide modules from editing and not display them ever.

That would probably super seed the custom priorities, however I don't think that this will conflict, the order is calculated based on module list, in the GUI, so a custom category wouldn't cause any issues (I think). The dragging of modules around is inherently better, however that could 1. build on this, 2. If they want to this can be removed.

@scorbett123 scorbett123 requested a review from 5HT2 February 15, 2021 18:29
@Luna5ama Luna5ama changed the title [enhancement] add ability to modify setting order. [enhancement] Added ability to modify setting order. Feb 16, 2021
Signed-off-by: scorbett123 <[email protected]>
@scorbett123 scorbett123 requested a review from Luna5ama February 16, 2021 10:49
@Luna5ama Luna5ama added --testing-pending Pending testing of the pull and removed --changes-requested Changes need to be made to the pull labels Feb 17, 2021
@5HT2 5HT2 added --changes-requested Changes need to be made to the pull and removed --testing-pending Pending testing of the pull labels Mar 2, 2021
@5HT2
Copy link
Member

5HT2 commented Mar 2, 2021

I cannot get the frequency mode to work, I tried toggling a couple modules a couple dozen times via the GUI, the other two modes work.

@5HT2 5HT2 modified the milestones: 2.03.01, 2.04.01 Mar 2, 2021
@scorbett123
Copy link
Contributor Author

I cannot get the frequency mode to work, I tried toggling a couple modules a couple dozen times via the GUI, the other two modes work.

Did you restart the GUI after toggling them?

@5HT2
Copy link
Member

5HT2 commented Mar 2, 2021

How?

@Luna5ama
Copy link
Contributor

Luna5ama commented Mar 2, 2021

How?

reopen the gui

@5HT2
Copy link
Member

5HT2 commented Mar 2, 2021

Yes, I did.

@scorbett123
Copy link
Contributor Author

Ok, will look at this tomorrow.

@scorbett123
Copy link
Contributor Author

@L1ving Sorry my mistake, the gui calls on toggle, however I moved it to on enable. It should work now.

@5HT2 5HT2 added --testing-pending Pending testing of the pull and removed --changes-requested Changes need to be made to the pull labels Mar 6, 2021
5HT2 added 2 commits March 12, 2021 22:24
# Conflicts:
#	src/main/kotlin/org/kamiblue/client/gui/clickgui/KamiClickGui.kt
#	src/main/kotlin/org/kamiblue/client/module/AbstractModule.kt
@5HT2 5HT2 merged commit e73d59c into kami-blue:master Mar 13, 2021
@5HT2
Copy link
Member

5HT2 commented Mar 13, 2021

Thanks!

@scorbett123
Copy link
Contributor Author

Thanks.

@scorbett123 scorbett123 deleted the advancedAi branch March 13, 2021 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
--testing-pending Pending testing of the pull -gui enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants