-
-
Notifications
You must be signed in to change notification settings - Fork 374
[enhancement] Added ability to modify setting order. #1938
Conversation
Signed-off-by: scorbett123 <[email protected]>
Part of #1648 |
src/main/kotlin/org/kamiblue/client/gui/clickgui/KamiClickGui.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/org/kamiblue/client/module/modules/combat/AutoOffhand.kt
Outdated
Show resolved
Hide resolved
I'm not quite sure what the how this relates to #1648 though |
Sort of fits in with Frequently used. |
Ah, I see. My thinking is this might conflict with My intention behind the idea is the user would be able to open the "category editing" and from there drag modules between any category in any order they want, and make their own categories. Preferably with a way to just hide modules from editing and not display them ever. |
That would probably super seed the custom priorities, however I don't think that this will conflict, the order is calculated based on module list, in the GUI, so a custom category wouldn't cause any issues (I think). The dragging of modules around is inherently better, however that could 1. build on this, 2. If they want to this can be removed. |
Signed-off-by: scorbett123 <[email protected]>
src/main/kotlin/org/kamiblue/client/gui/clickgui/KamiClickGui.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: scorbett123 <[email protected]>
I cannot get the frequency mode to work, I tried toggling a couple modules a couple dozen times via the GUI, the other two modes work. |
Did you restart the GUI after toggling them? |
How? |
reopen the gui |
Yes, I did. |
Ok, will look at this tomorrow. |
@L1ving Sorry my mistake, the gui calls on toggle, however I moved it to on enable. It should work now. |
# Conflicts: # src/main/kotlin/org/kamiblue/client/gui/clickgui/KamiClickGui.kt # src/main/kotlin/org/kamiblue/client/module/AbstractModule.kt
Signed-off-by: lv <[email protected]>
Thanks! |
Thanks. |
This enhanced machine learning allows for the filtering of module lists. Either through custom priority, the amount of clicks, or just alphabetically.
Unfortunately, I had to change the names of 2 other settings due to adding a setting to the base Abstract Module that was named the same.