Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests #384

Merged
merged 3 commits into from
Mar 24, 2023
Merged

Improve tests #384

merged 3 commits into from
Mar 24, 2023

Conversation

piegamesde
Copy link
Contributor

No description provided.

kamadorueda
kamadorueda previously approved these changes Mar 24, 2023
Copy link
Owner

@kamadorueda kamadorueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reason why it was not in.nix before is just that it would get autoformatted by Alejandra, but we can do it for the sake of having syntax highlighting

@kamadorueda
Copy link
Owner

the reason why it was not in.nix before is just that it would get autoformatted by Alejandra, but we can do it for the sake of having syntax highlighting

Mostly this one, which formats all *.nix in the repository, we would need to exclude the tests:

https://github.com/kamadorueda/alejandra/blob/main/treefmt.toml#L3-L6

Having the file extension makes it easier for editors to do syntax highlighting.
This should be checked in CI, really.
@piegamesde
Copy link
Contributor Author

Ah, I see. Should be fixed now. Btw treefmt for me does not use the nightly formatter, which messes everything up.

@kamadorueda kamadorueda merged commit d00d03f into kamadorueda:main Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants