feat(FEC-13946): Player core - Use shaka preload mechanism during playlist playback #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SivanA-Kaltura
requested review from
JonathanTGold,
semarche-kaltura and
lianbenjamin
MosheMaorKaltura
previously approved these changes
Jun 18, 2024
semarche-kaltura
previously approved these changes
Jun 20, 2024
SivanA-Kaltura
added a commit
to kaltura/playkit-js
that referenced
this pull request
Jun 23, 2024
…ylist playback (#780) ### Description of the Changes - Add setCachedUrls API - Pass the arguments to the adapter setCachedUrls API once an adapter is available Related PRs: kaltura/playkit-js-dash#262 kaltura/kaltura-player-js#792 Resolves FEC-13946
SivanA-Kaltura
dismissed stale reviews from semarche-kaltura and MosheMaorKaltura
via
3dc1ba5
semarche-kaltura
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
preloadManager instances only work with the shaka player that they were created by, which required the following changes:
Instead of having one instance of shaka per adapter we now have one shared instance per player (mapped by video element id)
Destroying a shaka instance invalidates its preloadManagers and also renders it unusable (forcing creation of a new instance) so it can only be destroyed if it has no preloadManagers
On destroy, if the cache is EMPTY, the instance will be destroyed and later it will be recreated on the next call to _init
If the cache is NOT EMPTY, the shaka instance will be detached instead of destroyed
Add adapter setCachedUrls API which adds / removes items from the cache
Update tests and add new tests to cover the setCachedUrls API
Related PRs:
kaltura/playkit-js#780
kaltura/kaltura-player-js#792
Resolves FEC-13946