Attempt to resolve a security alert related to xmldom
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 16, 2024 13:14
…pendabot's security alert about `xmldom` by updating the version of `msw` (= by issuing `npm uninstall msw` and then `npm install --save-dev msw`)
…o address Dependabot's security alert about `xmldom` by updating the version of `msw` (= by issuing `npm uninstall msw` and then `npm install --save-dev msw`)" This reverts commit 8ef6ee0.
kaloyan-marinov
deleted the
2024/03/16/13_14/50/attempt-to-resolve-a-security-alert-related-to-xmldom
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an earlier pull request in this repository attempted to address
this security alert related to the
xmldompackageby updating the
mswpackage from"msw": "^0.29.0"to"msw": "^1.3.2";the rationale for that approach was based on this;
unfortunately,
that pull request broke the frontend sub-project;
correspondigly, that pull request was undone within the following pull request,
and more specifically via this commit;
in the time between "the earlier pull request" and now,
a version 2 of
mswhas become available,with version 1 still being supported;
I attempted to update from
"msw": "^0.29.0"to version 2by following these instructions for resolving one of the frequent issues arising when updating from version 1 to version 2,
but failed to get things to work;
for convenience,
here are a few screenshots from that link:
the prospect of sneaking
a change of the testing framework used by the frontend sub-project
into this pull request
seemed so unsettling that I searched for more information on the matter,
which led me to this discussion;
in view of the following comment on that discussion:
I decided for this pull request to
update from
"msw": "^0.29.0"to version 1