Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Image Display Issues in .adoc Files for Chapters 01-11 #35

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

virtualvasu
Copy link

@virtualvasu virtualvasu commented Jul 4, 2024

This pull request fixes the issue where images were not being displayed in the .adoc files for chapters 01 through 11.

Changes:

  • Updated "baseimagedir" with the correct path.

Testing

  • Checked the output to ensure all images appear as expected in the final documents.

Additional Notes

  • Please review the changes to ensure there are no missing or incorrect image references.
  • Let me know if there are any additional adjustments needed.

@kallerosenbaum
Copy link
Owner

Thanks for the PR. I haven't put any effort in making the book readable directly on github, because there are typesetting, formulas, etc that aren't possible to render on github, only through building it properly using asciidoctor in accordance with the instructions in the readme. The book is available for readers in its full glory on https://rosenbaum.se/book/

Your PR is a strict improvement in terms of readability on github, but since a lot of other stuff isn't displayed correctly anyway, I'm hesitant to merge it. As an example of issues that are still not solved:

image

  • Latex formulas are not correctly rendered
  • The stuff that goes into the gutter (right margin) in the properly built book is displayed inline on github
  • The figure references contain the full figure caption

I'm not sure these issues are solvable, as github's asciidoc rendering isn't compatible with all asciidoctor features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants