-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Image Display Issues in .adoc Files for Chapters 01-11 #35
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR. I haven't put any effort in making the book readable directly on github, because there are typesetting, formulas, etc that aren't possible to render on github, only through building it properly using asciidoctor in accordance with the instructions in the readme. The book is available for readers in its full glory on https://rosenbaum.se/book/ Your PR is a strict improvement in terms of readability on github, but since a lot of other stuff isn't displayed correctly anyway, I'm hesitant to merge it. As an example of issues that are still not solved:
I'm not sure these issues are solvable, as github's asciidoc rendering isn't compatible with all asciidoctor features. |
This pull request fixes the issue where images were not being displayed in the
.adoc
files for chapters 01 through 11.Changes:
Testing
Additional Notes