Skip to content

Pass the no_attributes flag when they are not needed#765

Merged
jlsjonas merged 1 commit intokalkih:devfrom
bdraco:pass_no_attributes
May 12, 2022
Merged

Pass the no_attributes flag when they are not needed#765
jlsjonas merged 1 commit intokalkih:devfrom
bdraco:pass_no_attributes

Conversation

@bdraco
Copy link
Copy Markdown
Contributor

@bdraco bdraco commented Mar 21, 2022

Copy link
Copy Markdown
Collaborator

@jlsjonas jlsjonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always good to improve performance, which scenarios did you personally test?

@bdraco
Copy link
Copy Markdown
Contributor Author

bdraco commented Mar 24, 2022

which scenarios did you personally test?

Tested with the following:

color_thresholds:
  - color: '#c0392b'
    value: 10
  - color: '#d35400'
    value: 5
  - color: '#f39c12'
    value: 3
decimals: 3
entities:
  - color: blue
    entity: sensor.powerwall_load_now
    index: 0
    name: House
  - color: cyan
    entity: sensor.combined_sensor_energy_usage
    index: 4
    name: Sense
  - color: gray
    entity: sensor.powerwall_site_now
    index: 1
    name: Grid
  - color: green
    entity: sensor.powerwall_battery_now
    index: 2
    name: Powerwall
  - color: yellow
    entity: sensor.powerwall_solar_now
    index: 3
    name: Solar
height: 300
name: Power Usage
show:
  labels: true
type: custom:mini-graph-card

@bdraco
Copy link
Copy Markdown
Contributor Author

bdraco commented Apr 5, 2022

Any chance this can get released before tomorrows home assistant release?

@bdraco bdraco force-pushed the pass_no_attributes branch from ec0c3c2 to 7c62dbb Compare May 4, 2022 03:44
@bdraco
Copy link
Copy Markdown
Contributor Author

bdraco commented May 4, 2022

I rebased this since master was force pushed

@jlsjonas jlsjonas merged commit 63248b2 into kalkih:dev May 12, 2022
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 0.12.0-dev.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 0.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@bdraco bdraco deleted the pass_no_attributes branch January 27, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants