Pass the no_attributes flag when they are not needed#765
Merged
jlsjonas merged 1 commit intokalkih:devfrom May 12, 2022
Merged
Conversation
jlsjonas
approved these changes
Mar 24, 2022
Collaborator
jlsjonas
left a comment
There was a problem hiding this comment.
Always good to improve performance, which scenarios did you personally test?
Contributor
Author
Tested with the following: |
Contributor
Author
|
Any chance this can get released before tomorrows home assistant release? |
- Reduces backend I/O by up to 90% - See related PR home-assistant/frontend#12082 - See related PR home-assistant/developers.home-assistant#1242
Contributor
Author
|
I rebased this since |
|
🎉 This PR is included in version 0.12.0-dev.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is backwards compatible, it will make a difference on 2022.4dev and later
Reduces backend I/O by up to 90%
See related PR Fetch history with
no_attributesfor entities that do not need them home-assistant/frontend#12082See related PR Document
no_attributesflag for history api home-assistant/developers.home-assistant#1242See related PR Avoid selecting attributes in the history api when
no_attributesis passed home-assistant/core#68352See related PR Separate attrs into another table (reduces database size) home-assistant/core#68224