Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: indicator style for the 1st state #1105

Merged
merged 3 commits into from
May 15, 2024
Merged

fix: indicator style for the 1st state #1105

merged 3 commits into from
May 15, 2024

Conversation

ildar170975
Copy link
Collaborator

Consider the code:

type: custom:mini-graph-card
entities:
  - entity: sensor.xiaomi_cg_1_co2
    show_state: true
    show_indicator: true
  - entity: sensor.xiaomi_cg_2_co2
    show_state: true
    show_indicator: true
  - entity: sensor.mijia_300_1_co2
    show_state: true
    show_indicator: true
name: xxx

Currently an indicator for the 1st state is misaligned & square:

изображение

After the fix:

изображение

@ildar170975
Copy link
Collaborator Author

ildar170975 commented May 15, 2024 •
edited
Loading

@akloeckner
Have no idea why - but the PR contains some other changes as well:
изображение
although I only proposed changes in style.js.

@akloeckner
Copy link
Collaborator

It's because I didn't pull the release-related commits into dev. I did that now.

I'll fix the semantic PR title and merge. 👍

@akloeckner akloeckner changed the title Fix indicator for the 1st state fix: indicator style for the 1st state May 15, 2024
@akloeckner akloeckner merged commit c0ad333 into kalkih:dev May 15, 2024
4 of 5 checks passed
@ildar170975
Copy link
Collaborator Author

Thanks a lot!

@ildar170975 ildar170975 deleted the fix-indicator branch May 15, 2024 22:41
github-actions bot pushed a commit that referenced this pull request Jul 24, 2024
@semantic-release-bot
chore(release): 0.12.2-dev.1 [skip ci]
ca543d5 
## [0.12.2-dev.1](v0.12.1...v0.12.2-dev.1) (2024-07-24)

### Bug Fixes

* indicator style for the 1st state ([#1105](#1105)) ([c0ad333](c0ad333))
* legend indicators respect entity attribute configuration ([#1115](#1115)) ([5fe01d1](5fe01d1))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 0.12.2-dev.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released on @dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ildar170975 @akloeckner @semantic-release-bot