NormalizeComponent with add-log-std option #482
Conversation
…of input variance.
src/nnet3/nnet-simple-component.h
Outdated
There was a problem hiding this comment.
you should call it add_log_stddev_, not add_log_std_.
Also, " is added as node to output layer." is not the right terminology as used in nnet3, its an extra dimension of the output.
|
changed option names to add-log-stddev. |
src/nnet3/nnet-component-itf.cc
Outdated
There was a problem hiding this comment.
if you don't need the assert statement then delete it.
src/nnet3/nnet-simple-component.cc
Outdated
There was a problem hiding this comment.
You wouldn't need to use a temporary matrix if you computed this before the other part of the input derivative.
…ome issues with NormalizeComponent.
|
fixed! |
src/nnet3/nnet-component-itf.cc
Outdated
| std::string NonlinearComponent::Info() const { | ||
| std::stringstream stream; | ||
| KALDI_ASSERT(InputDim() == OutputDim()); // always the case | ||
| stream << Type() << ", dim=" << InputDim(); |
There was a problem hiding this comment.
You should extend the Info(), so that it's clear from the info string whether you have this extra feature.
Probably if the feature is included, it should say input-dim=xxx, output-dim=xxx, include-log-stddev=true
There was a problem hiding this comment.
pegah, you still haven't done this (fix the info string)
There was a problem hiding this comment.
I had extended the NormalizeComponent::Info() to contain input-output dim if add-log-stddev is true.
I modified NonlinearComponent::Info() . Is this what you asked for?
|
Fixed! |
|
I see- looks right. |
NormalizeComponent with add-log-std option
2 participants
No description provided.