Windows docs #448
Merged
Windows docs #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It previously didn't mention that you need --enable-openblas (if using OpenBLAS).
Contributor
|
Thanks. The issue I see with the rendering is that it does not show the alternative paths properly -- in the original readme, openblas and MKL are alternatives -- there is no distinction of this kind in the rendered markdown |
Contributor
|
Yenda, please merge this (or not) as you see fit... |
Contributor
Author
|
I agree about the alternatives. To be honest I don't think it was that clear in the original, but anyway - give me a few days and I'll improve this patch so it is explicit. |
Contributor
Author
|
Hopefully this is ok. Thanks for merging my other pull requests by the way! |
Contributor
|
@jtrmal, please look into this one to.. |
Contributor
|
That looks fine. Thanks. Merging. y. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reformatted the Windows INSTALL file so it is markdown (nicely rendered by Github):
https://github.com/Timmmm/kaldi/blob/windows_docs/windows/INSTALL.md
I had to rename it to .md so Github will render it. I also added a note about using --enable-openblas.