Windows docs #445
Merged
Windows docs #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 11, 2016 10:49
There were some stray tabs in the Windows INSTALL file.
Annoyingly, github's zip download doesn't seem to preserve line endings. See http://stackoverflow.com/questions/17347611/downloading-a-zip-from-github-removes-newlines-from-text-files
Should be fixed in the windows_line_endings branch.
Contributor
|
Tim, would you mind squashing this into one commit if you know how these things are done? Otherwise, let me know and I'll merge this. |
Contributor
|
Actually, I reviewed the patch again and I think it's good as it it (as each of the commits is fairly limited in scope and well isolated). Perhaps we should wait with the merge until #444 will get resolved (as this patch removes the info about the issues re downloading the archive). |
Contributor
|
Merging. Thanks Tim. y. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert tabs to spaces for consistency, and also add a note about the patch line ending issue in case people have problems.