Skip to content

add doc for kaldi pybind.#3967

Merged
danpovey merged 1 commit intokaldi-asr:pybind11from
mobvoi:fangjun-doc
Mar 2, 2020
Merged

add doc for kaldi pybind.#3967
danpovey merged 1 commit intokaldi-asr:pybind11from
mobvoi:fangjun-doc

Conversation

@csukuangfj
Copy link
Contributor

As mentioned in danpovey#87 (comment)
and https://groups.google.com/forum/#!topic/kaldi10-design/BYSkonhkiwc, we are starting to add documentation for kaldi pybind.

The following is a screenshot showing what the generated documentation looks like.

You can access it from https://kaldi-pybind.imfast.io/index.html

Screen Shot 2020-03-01 at 23 52 44


For developers, you can follow https://github.com/mobvoi/kaldi/blob/fangjun-doc/src/pybind/doc/developers.md to generate documentation locally.

The following is a screenshot from my local computer:

Screen Shot 2020-03-01 at 23 56 23


@danpovey @jtrmal
please have a reivew.

The generated HTML files can be hosted at https://kaldi-asr.org/doc/
in a subdirectory, say pybind.

@danpovey
Copy link
Contributor

danpovey commented Mar 2, 2020

This looks good to me. Of course, the different style vs. doxygen is not ideal, but we have to face the fact that doxygen is getting less popular. Any other comments before I merge?

@csukuangfj
Copy link
Contributor Author

Doxygen is suitable for generating documentation for C++ code.

Nowadays, I think Sphinx is very popular for generating documentation for Python code.

I find that this project https://exhale.readthedocs.io/en/latest/ can parse Doxygen style
comments into the sphinx domain. Maybe we can convert the current C++ documentation.

Sphinx also supports markdown files.


I think we have to upload the generated HTML files to the kaldi doc server.
Is it possible to make this process automatically once a pullrequest is merged?

@danpovey
Copy link
Contributor

danpovey commented Mar 2, 2020 via email

Copy link
Contributor

jtrmal commented Mar 2, 2020

yeah i will look at the tomorrow

@danpovey
Copy link
Contributor

danpovey commented Mar 2, 2020

Merging this too...

@danpovey danpovey merged commit 261eee1 into kaldi-asr:pybind11 Mar 2, 2020
@galv
Copy link
Contributor

galv commented Mar 3, 2020

A lot of problems with exhale were worked out for the sake of pytorch's C++ interface. It should just work, as the say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants