fix a typo for natural gradient #3034
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpovey
reviewed
Feb 15, 2019
|
|
||
| Now, a note on what we do on time t = 0, i.e. for the first minibatch. We | ||
| initialize X_0 to the top R eigenvectors of 1/N X_0 X_0^T, where N is the | ||
| initialize R_0 to the top R eigenvectors of 1/N X_0 X_0^T, where N is the |
Contributor
There was a problem hiding this comment.
I think there might be another problem here. I believe X is (N by D) where N is the minibatch size. (Although elsewhere I seem to have used M for the minibatch size so that might be a better letter). We want the eigenvectors of a D x D matrix, so it should be X_0^T X_0. That appears in the lines immediately below, too.
Contributor
|
closing this because I have some more extensive fixes I want to merge about those comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit is simple. but it is essential for some people trying to understand the natural gradient method.