Skip to content

[scripts,src] Fix to multitask nnet3 training (#2818); cosmetic code change. #2827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danpovey merged 1 commit into from
Nov 8, 2018
Merged

[scripts,src] Fix to multitask nnet3 training (#2818); cosmetic code change. #2827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion egs/wsj/s5/steps/libs/nnet3/train/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,12 @@ def get_multitask_egs_opts(egs_dir, egs_prefix="",
'--output=ark:foo/egs/output.3.ark --weight=ark:foo/egs/weights.3.ark'
i.e. egs_prefix is "" for train and
"valid_diagnostic." for validation.

Caution: archive_index is usually an integer, but may be a string ("JOB")
in some cases.
"""
multitask_egs_opts = ""
egs_suffix = ".{0}".format(archive_index) if archive_index > -1 else ""
egs_suffix = ".{0}".format(archive_index) if archive_index != -1 else ""

if use_multitask_egs:
output_file_name = ("{egs_dir}/{egs_prefix}output{egs_suffix}.ark"
Expand Down
2 changes: 1 addition & 1 deletion src/rnnlm/rnnlm-example-utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ static void ProcessRnnlmOutputNoSampling(
row_sums.ApplyLog();
BaseFloat ans = -VecVec(row_sums, minibatch.output_weights);
*objf_den_exact = ans;
if (fabs(ans) > 100) {
if (fabs(ans) > 1.0 * nnet_output.NumRows()) {
KALDI_WARN << "Big den objf " << ans;
}
}
Expand Down