Recipe for Tunisian_MSA corpus. #2722
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ything under data/local
…l number of jobs to 1.
…-chunk-per-minibatch=64,32,16
…l number of jobs to 1.
…nstead of data/lang in mkgraph command
Contributor
Author
|
It looks like I was not able to resolve the conflicts. I accept help :) |
Contributor
|
OK @xiaohui-zhang and @huangruizhe will look at it. |
Contributor
|
The conflicts seem to be due to changes to files in the heroico recipe that don't seem to be related to the Tunisian MSA recipe. |
Contributor
|
done in #2725 |
…oded Arabic to utf8 encoded arabic.
…buckwalter to utf8.
| @@ -0,0 +1,10 @@ | |||
| #!/bin/bash | |||
|
|
|||
| cut -d " " -f 1 qcri.txt > qcri_words_buckwalter.txt | |||
Contributor
There was a problem hiding this comment.
this should probably be
cat qcri.txt | tail -n +4 | cut -d " " -f 1 > qcri_words_buckwalter.txt
cat qcri.txt | tail -n +4 | cut -d " " -f 2 > qcri_prons.txt
Otherwise lines like "# Copyright" will be included.
Contributor
Author
|
I was already doing this in the download script:
egs/Tunisian_msa/s5/local/qcri_lexicon_download.sh
I wasn't overwriting the unzipped text file with the header removed,
so I fixed that.
J
…On 9/20/18, Xiaohui Zhang ***@***.***> wrote:
xiaohui-zhang commented on this pull request.
> @@ -0,0 +1,10 @@
+#!/bin/bash
+
+cut -d " " -f 1 qcri.txt > qcri_words_buckwalter.txt
this should probably be
cat qcri.txt | tail -n +4 | cut -d " " -f 1 > qcri_words_buckwalter.txt
cat qcri.txt | tail -n +4 | cut -d " " -f 2 > qcri_prons.txt
Otherwise lines like "# Copyright" will be included.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#2722 (review)
|
| #!/bin/bash | ||
|
|
||
| cut -d " " -f 1 qcri.txt > qcri_words_buckwalter.txt | ||
| cut -d " " -f 2 qcri.txt > qcri_prons.txt |
Contributor
There was a problem hiding this comment.
Actually the option -f 2 should be -f 2-. I realized this after I saw totally wrong decoding results...
Contributor
|
I'm closing this PR because I believe we merged it indirectly via #2725. If there are other changes you want us to merge, please let us know. |
Contributor
Author
|
I removed 2 scripts that are not used and 2 config files. And I added a copyright.
conf/pitch.conf
conf/plp.conf
local/buckwalter2utf8.pl
local/qcri_buckwalter2utf8.pl
John
… On Sep 30, 2018, at 2:48 PM, Daniel Povey ***@***.***> wrote:
I'm closing this PR because I believe we merged it indirectly via #2725 <#2725>. If there are other changes you want us to merge, please let us know.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#2722 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABK_gOfxFNhOYOYXKrEObm3ltCrzm-32ks5ugRH5gaJpZM4Wwdhl>.
|
Contributor
|
@xiaohui-zhang would you mind making a PR with the latest changes, if appropriate? No hurry. |
Contributor
|
sure!
…On Sun, Sep 30, 2018 at 8:31 PM Daniel Povey ***@***.***> wrote:
@xiaohui-zhang <https://github.com/xiaohui-zhang> would you mind making a
PR with the latest changes, if appropriate? No hurry.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2722 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ANiEEa2y0aKL2fkc0ml6gY1MKYNSrvrHks5ugWJHgaJpZM4Wwdhl>
.
--
Xiaohui
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recipe to build an ASR system with the Tunisian_MSA corpus of Arabic.