Skip to content

[src] Fix nnet1 proj-lstm bug where gradient clipping not used; thx:@cbtpkzm #2696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danpovey merged 1 commit into from
Sep 11, 2018
Merged

[src] Fix nnet1 proj-lstm bug where gradient clipping not used; thx:@cbtpkzm #2696

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 15 additions & 18 deletions src/nnet/nnet-lstm-projected.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,21 +655,21 @@ class LstmProjected : public MultistreamComponent {
const CuMatrixBase<BaseFloat> &diff) {

// apply the gradient clipping,
if (clip_gradient_ > 0.0) {
w_gifo_x_corr_.ApplyFloor(-clip_gradient_);
w_gifo_x_corr_.ApplyCeiling(clip_gradient_);
w_gifo_r_corr_.ApplyFloor(-clip_gradient_);
w_gifo_r_corr_.ApplyCeiling(clip_gradient_);
bias_corr_.ApplyFloor(-clip_gradient_);
bias_corr_.ApplyCeiling(clip_gradient_);
w_r_m_corr_.ApplyFloor(-clip_gradient_);
w_r_m_corr_.ApplyCeiling(clip_gradient_);
peephole_i_c_corr_.ApplyFloor(-clip_gradient_);
peephole_i_c_corr_.ApplyCeiling(clip_gradient_);
peephole_f_c_corr_.ApplyFloor(-clip_gradient_);
peephole_f_c_corr_.ApplyCeiling(clip_gradient_);
peephole_o_c_corr_.ApplyFloor(-clip_gradient_);
peephole_o_c_corr_.ApplyCeiling(clip_gradient_);
if (grad_clip_ > 0.0) {
w_gifo_x_corr_.ApplyFloor(-grad_clip_);
w_gifo_x_corr_.ApplyCeiling(grad_clip_);
w_gifo_r_corr_.ApplyFloor(-grad_clip_);
w_gifo_r_corr_.ApplyCeiling(grad_clip_);
bias_corr_.ApplyFloor(-grad_clip_);
bias_corr_.ApplyCeiling(grad_clip_);
w_r_m_corr_.ApplyFloor(-grad_clip_);
w_r_m_corr_.ApplyCeiling(grad_clip_);
peephole_i_c_corr_.ApplyFloor(-grad_clip_);
peephole_i_c_corr_.ApplyCeiling(grad_clip_);
peephole_f_c_corr_.ApplyFloor(-grad_clip_);
peephole_f_c_corr_.ApplyCeiling(grad_clip_);
peephole_o_c_corr_.ApplyFloor(-grad_clip_);
peephole_o_c_corr_.ApplyCeiling(grad_clip_);
}

const BaseFloat lr = opts_.learn_rate;
Expand Down Expand Up @@ -698,9 +698,6 @@ class LstmProjected : public MultistreamComponent {
// buffer for transfering state across batches,
CuMatrix<BaseFloat> prev_nnet_state_;

// gradient-clipping value,
BaseFloat clip_gradient_;

// feed-forward connections: from x to [g, i, f, o]
CuMatrix<BaseFloat> w_gifo_x_;
CuMatrix<BaseFloat> w_gifo_x_corr_;
Expand Down