Skip to content

these arguments should be const-reference #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danpovey merged 1 commit into from
Jul 26, 2018
Merged

these arguments should be const-reference #2576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/tree/context-dep.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,8 +319,8 @@ void ContextDependency::GetPdfInfo(


ContextDependency*
MonophoneContextDependency(const std::vector<int32> phones,
const std::vector<int32> phone2num_pdf_classes) {
MonophoneContextDependency(const std::vector<int32> &phones,
const std::vector<int32> &phone2num_pdf_classes) {
std::vector<std::vector<int32> > phone_sets(phones.size());
for (size_t i = 0; i < phones.size(); i++) phone_sets[i].push_back(phones[i]);
std::vector<bool> share_roots(phones.size(), false); // don't share roots.
Expand All @@ -331,8 +331,8 @@ MonophoneContextDependency(const std::vector<int32> phones,
}

ContextDependency*
MonophoneContextDependencyShared(const std::vector<std::vector<int32> > phone_sets,
const std::vector<int32> phone2num_pdf_classes) {
MonophoneContextDependencyShared(const std::vector<std::vector<int32> > &phone_sets,
const std::vector<int32> &phone2num_pdf_classes) {
std::vector<bool> share_roots(phone_sets.size(), false); // don't share roots.
// N is context size, P = position of central phone (must be 0).
int32 num_leaves = 0, P = 0, N = 1;
Expand Down
8 changes: 4 additions & 4 deletions src/tree/context-dep.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,15 +180,15 @@ ContextDependency *GenRandContextDependencyLarge(const std::vector<int32> &phone
// 0, 1, 2).

ContextDependency*
MonophoneContextDependency(const std::vector<int32> phones,
const std::vector<int32> phone2num_pdf_classes);
MonophoneContextDependency(const std::vector<int32> &phones,
const std::vector<int32> &phone2num_pdf_classes);

// MonophoneContextDependencyShared is as MonophoneContextDependency but lets
// you define classes of phones which share pdfs (e.g. different stress-markers of a single
// phone.) Each element of phone_classes is a set of phones that are in that class.
ContextDependency*
MonophoneContextDependencyShared(const std::vector<std::vector<int32> > phone_classes,
const std::vector<int32> phone2num_pdf_classes);
MonophoneContextDependencyShared(const std::vector<std::vector<int32> > &phone_classes,
const std::vector<int32> &phone2num_pdf_classes);


// Important note:
Expand Down