[scripts] Fix to analyze_alignments/lats.sh (double-counting) #2573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a single phoneme is aligned to the whole utterance, it is counted both as `begin` and `end`, but is added to the total only once. This caused `assert count >= 0` in analyze_phone_length_stats.py to fail. Now only the `begin` is counted in that case.
Contributor
|
OK. It seems to mess with the expected meanings of the counts, but I can't see a better way to resolve the issue that's easy, so I'll merge this. |
dpriver
pushed a commit
to dpriver/kaldi
that referenced
this pull request
Sep 13, 2018
…asr#2573) If a single phoneme is aligned to the whole utterance, it is counted both as `begin` and `end`, but is added to the total only once. This caused `assert count >= 0` in analyze_phone_length_stats.py to fail. Now only the `begin` is counted in that case.
Skaiste
pushed a commit
to Skaiste/idlak
that referenced
this pull request
Sep 26, 2018
…asr#2573) If a single phoneme is aligned to the whole utterance, it is counted both as `begin` and `end`, but is added to the total only once. This caused `assert count >= 0` in analyze_phone_length_stats.py to fail. Now only the `begin` is counted in that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a single phoneme is aligned to the whole utterance, it is counted both as
beginandend, but is added to the total only once. This causedassert count >= 0inanalyze_phone_length_stats.pyto fail (count = all - begin - end).I'm not sure what the ideal behavior is, but in this change only the
beginis counted in such cases.