Conversation
Contributor
|
Looks plausible. It's been tested somehow? |
Contributor
Author
|
yes, I am doing some large scale experiments on multi_en, and this issue was very evident. I did test the fix today and seem to work as expected. |
dpriver
pushed a commit
to dpriver/kaldi
that referenced
this pull request
Sep 13, 2018
Skaiste
pushed a commit
to Skaiste/idlak
that referenced
this pull request
Sep 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this is a fix to this PR: https://github.com/kaldi-asr/kaldi/pull/2414/files
It originally added reco2dur bits to speed perturbation scripts (so perturb_data_dir_speed_3way.sh takes care of that, and then reverberation scripts do not need to recompute durations at the recording level).
The issue is, that although perturb_data_dir_speed_3way.sh computes reco2dur for the source folder (if it's missing), perturb_data_dir_speed.sh is not modifying it for speed perturbed variants. As a result reco2dur does not exists in speed perturbed folders, and combine_data.sh later omits it when creating _sp data dir. Which is a problem for reverberate_data_dir.py later (as it tries to recompute it from scratch).