Add util to compute recordings durations before data perturbation#2414
Merged
danpovey merged 2 commits intokaldi-asr:masterfrom May 14, 2018
Merged
Add util to compute recordings durations before data perturbation#2414danpovey merged 2 commits intokaldi-asr:masterfrom
danpovey merged 2 commits intokaldi-asr:masterfrom
Conversation
danpovey
reviewed
May 11, 2018
| fi | ||
|
|
||
| if [ -s $data/utt2dur ] && \ | ||
| [ $(cat $data/utt2spk | wc -l) -eq $(cat $data/utt2dur | wc -l) ] && \ |
Contributor
There was a problem hiding this comment.
you could do
wc -l <$data/utt2spk to avoid the 'cat'.
Contributor
|
Thanks! I commented on the original thread- I hope the guy who reported the problem can help test it. |
Contributor
|
Thanks. Have you at least tested that this runs? I may merge without waiting for that guy to test. |
Contributor
Author
|
Yes, I've tested it on a dataset with a segments file and everything works as it should; durations are as reported by soxi, validate_data_dir outputs if there's missing lines in the file and fix_data_dir filters out what's not in wav.scp. |
Contributor
|
Thanks for doing this! Merged. |
danpovey
added a commit
to danpovey/kaldi
that referenced
this pull request
May 21, 2018
danpovey
added a commit
that referenced
this pull request
May 21, 2018
dpriver
pushed a commit
to dpriver/kaldi
that referenced
this pull request
Sep 13, 2018
dpriver
pushed a commit
to dpriver/kaldi
that referenced
this pull request
Sep 13, 2018
Skaiste
pushed a commit
to Skaiste/idlak
that referenced
this pull request
Sep 26, 2018
Skaiste
pushed a commit
to Skaiste/idlak
that referenced
this pull request
Sep 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #2388. I'd like some help to test more extensively, especially in the case where recording-ids are the same as utt-ids, as a bug could have a big impact