make the install script fetch changes from github repo and fix instal…#2323
Merged
danpovey merged 1 commit intokaldi-asr:masterfrom Mar 30, 2018
Merged
Conversation
…lation issue for new setuptools
Contributor
Author
|
@langep any comments from python perspective? |
Contributor
|
I started to use |
Contributor
|
Oh sorry, I thought this was the original issue. I will take a look but it should work with newest sequitur version |
Contributor
|
Looks good. Modifying PYTHONPATH is required if not called from within the sequitur-g2p root. It might work without it if we are in there already. |
Contributor
Author
|
Thanks -- I introduced these things because even the setup.py was refusing
to work without being it set up.
@danpovey, if you are ok with this, please merge (this is orthogonal
to the error report we had yesterday).
y.
…On Thu, Mar 29, 2018 at 5:13 PM, Patrick L. Lange ***@***.***> wrote:
Looks good. Modifying PYTHONPATH is required if not called from within the
sequitur-g2p root. It might work without it if we are in there already.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2323 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AKisXyZWfOkIyh-y8-x7AdbCzPVwP5H0ks5tjU5_gaJpZM4TA-mC>
.
|
LvHang
pushed a commit
to LvHang/kaldi
that referenced
this pull request
Apr 14, 2018
…th new setuptools) (kaldi-asr#2323)
chenzhehuai
pushed a commit
to chenzhehuai/kaldi
that referenced
this pull request
May 23, 2018
…th new setuptools) (kaldi-asr#2323)
Skaiste
pushed a commit
to Skaiste/idlak
that referenced
this pull request
Sep 26, 2018
…th new setuptools) (kaldi-asr#2323)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lation issue for new setuptools