Skip to content

add bos and eos check in RnnlmComputeStateInfo #2314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danpovey merged 2 commits into from
Mar 27, 2018
Merged

add bos and eos check in RnnlmComputeStateInfo #2314

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e974192
add bos and eos check in RnnlmComputeStateInfo
hainan-xv Mar 26, 2018
73494b3
add assertion for AddWord function in RnnlmComputeState
hainan-xv Mar 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/rnnlm/rnnlm-compute-state.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,14 @@ RnnlmComputeStateInfo::RnnlmComputeStateInfo(
KALDI_ERR << "Embedding file and nnet have different embedding sizes. ";
}

if (opts.bos_index <= 0 || opts.bos_index >= word_embedding_mat.NumRows()) {
KALDI_ERR < "--bos-symbol option isn't set correctly.";
}

if (opts.eos_index <= 0 || opts.eos_index >= word_embedding_mat.NumRows()) {
KALDI_ERR < "--eos-symbol option isn't set correctly.";
}

nnet3::ComputationRequest request1, request2, request3;
CreateLoopedComputationRequestSimple(rnnlm,
1, // num_frames
Expand Down Expand Up @@ -85,6 +93,7 @@ RnnlmComputeState* RnnlmComputeState::GetSuccessorState(int32 next_word) const {
}

void RnnlmComputeState::AddWord(int32 word_index) {
KALDI_ASSERT(word_index > 0 && word_index < info_.word_embedding_mat.NumRows());
previous_word_ = word_index;
AdvanceChunk();

Expand Down