fix reading wavs produced on iPhones with extra RIFF tags. #2293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarelVesely84
force-pushed
the
iphone_wav
branch
from
1e04db5 to
0440919
Compare
danpovey
reviewed
Mar 20, 2018
src/feat/wave-reader.cc
Outdated
| while (strcmp(reader.tag,"fmt ") != 0) { | ||
| uint32 filler_size = reader.ReadUint32(); | ||
| riff_chunk_read += 4; | ||
| KALDI_WARN << "Skipping RIFF tag '" << reader.tag |
Contributor
There was a problem hiding this comment.
I don't imagine you want that warning there permanently...
KarelVesely84
force-pushed
the
iphone_wav
branch
from
0440919 to
3738fa0
Compare
- Apple creates wavs with extra RIFF tags for optimizing memory layout,
- instead of standard 'RIFF,WAVE,fmt ,data'
we observed a file with 'RIFF,WAVE,JUNK,fmt ,FLLR,data'
- according to RIFF specs, we should skip the unknown tags, which is
what the fix does, as it skips the 'JUNK', the skip of 'FLLR' was
already in the code.
- similar problem discussed in: https://stackoverflow.com/questions/6284651/avaudiorecorder-doesnt-write-out-proper-wav-file-header
- Please let me know if you'd like to refactor the code,
i can imagine there could be a method 'ProceedToTag("ABCD")',
which skips tags until it reaches 'ABCD', but this would change
more of the code, also 'byte-counting' would be more diffcult...
- The code as in this PR already solves the issue, and the changes
are smallest possible.
KarelVesely84
force-pushed
the
iphone_wav
branch
from
3738fa0 to
830c623
Compare
Contributor
Author
|
Okay, the warning-print is now removed. The code is tested on both the Apple and non-Apple wavefile... |
LvHang
pushed a commit
to LvHang/kaldi
that referenced
this pull request
Apr 14, 2018
Skaiste
pushed a commit
to Skaiste/idlak
that referenced
this pull request
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple creates wavs with extra RIFF tags for optimizing memory layout,
we observed a file with 'RIFF,WAVE,JUNK,fmt ,FLLR,data'
what the fix does, as it skips the 'JUNK', the skip of 'FLLR' was
already in the code.
Please let me know if you'd like to do further refactoring of the code,
i can imagine there could be a method 'ProceedTo4ByteTag("ABCD")',
which would skip tags until it reaches 'ABCD' and returns number of bytes read...
On the other hand, the code in this PR already solves the issue, and the changes are the smallest possible.