Add support for --use-gpu=wait to nnet3 scripts #2289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpovey
reviewed
Mar 17, 2018
| run_opts = common_train_lib.RunOpts() | ||
| if args.use_gpu: | ||
| if args.use_gpu in ["true", "false"]: | ||
| args.use_gpu = {'true': 'yes', 'false': 'no'}[args.use_gpu] |
Contributor
There was a problem hiding this comment.
I'd prefer if you wrote this as
args.gpu = ("yes" if args.gpu == "true" else "no")
as it's easier for a human to parse.
Otherwise this is OK.
danpovey
reviewed
Mar 17, 2018
| action=common_lib.StrToBoolAction, | ||
| choices=["true", "false"], | ||
| help="Use GPU for training", default=True) | ||
| choices=["true", "false", "yes", "no", "wait"], |
Contributor
There was a problem hiding this comment.
You should probably mention that "true" and "false" are deprecated.
Contributor
|
Thanks-- merging. |
LvHang
pushed a commit
to LvHang/kaldi
that referenced
this pull request
Apr 14, 2018
Skaiste
pushed a commit
to Skaiste/idlak
that referenced
this pull request
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@danpovey, could you please see if this is how you meant for this to be done?
If yes, I'll make changes to the rest of the nnet3 scripts.