Merged
Conversation
Contributor
Author
|
This is ready to be merged. |
danpovey
reviewed
Mar 14, 2018
| for p in $garbage_phones; do | ||
| for affix in "" "_B" "_E" "_I" "_S"; do | ||
| for a in "" "_B" "_E" "_I" "_S"; do | ||
| echo "$p$affix" |
Contributor
There was a problem hiding this comment.
this doesn't look right to me.
|
|
||
| sad_nnet_dir=exp/segmentation${affix}/tdnn_stats_asr_sad_1a | ||
| sad_nnet_dir=$dir/tdnn_stats_asr_sad_1a | ||
| sad_opts="--extra-left-context 79 --extra-right-context 21 --frames-per-chunk 150 --extra-left-context-initial 0 --extra-right-context-final 0 --acwt 0.3" |
Contributor
There was a problem hiding this comment.
you could remove the comments if they are not relevant any more.
and you should probably explain where you got the "opts" from, e.g. do they need to match something else in another script?
Contributor
Author
|
Fixed. |
Contributor
|
@olix20, can you please check if this resolves your problems? |
Contributor
|
I'm merging but @olix20, please let us know if you find further problems. |
gorinars
pushed a commit
to gorinars/kaldi
that referenced
this pull request
Mar 22, 2018
This reverts commit 322f698.
LvHang
pushed a commit
to LvHang/kaldi
that referenced
this pull request
Apr 14, 2018
Skaiste
pushed a commit
to Skaiste/idlak
that referenced
this pull request
Sep 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for a bug that occurs in certain cases.
Also fixes #2269