Skip to content

end2end chain: Fix 2 issues Re chain.l2_term and numerator backward computation #2270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danpovey merged 1 commit into from
Mar 12, 2018
Merged

end2end chain: Fix 2 issues Re chain.l2_term and numerator backward computation #2270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/chain/chain-training.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,9 @@ void ComputeChainObjfAndDerivE2e(const ChainTrainingOptions &opts,
if (nnet_output_deriv)
nnet_output_deriv->AddMat(1.0, *xent_output_deriv);
} else if (nnet_output_deriv && numerator_ok) {
numerator.Backward(nnet_output_deriv);
numerator_ok = numerator.Backward(nnet_output_deriv);
if (!numerator_ok)
KALDI_LOG << "Numerator backward failed.";
}
}

Expand Down Expand Up @@ -128,9 +130,8 @@ void ComputeChainObjfAndDerivE2e(const ChainTrainingOptions &opts,
KALDI_LOG << "Derivs per frame are " << row_products_per_frame;
}

if (opts.l2_regularize == 0.0) {
*l2_term = 0.0;
} else if (numerator_ok) { // we should have some derivs to include a L2 term
*l2_term = 0.0;
if (opts.l2_regularize != 0.0 && numerator_ok) { // we should have some derivs to include a L2 term
// compute the l2 penalty term and its derivative
BaseFloat scale = supervision.weight * opts.l2_regularize;
*l2_term = -0.5 * scale * TraceMatMat(nnet_output, nnet_output, kTrans);
Expand Down